Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend: use webp thumbnails #1766

Merged
merged 2 commits into from
Apr 9, 2024
Merged

frontend: use webp thumbnails #1766

merged 2 commits into from
Apr 9, 2024

Conversation

SamuelPull
Copy link
Collaborator

@SamuelPull SamuelPull commented Apr 8, 2024 •
edited
Loading

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

How to test

You might need to rebuild frontend container image

Closes #1753

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024 •
edited
Loading

Warnings
⚠️ No CHANGELOG added.
⚠️ There were changes in the frontend, but no E2E-test was added or modified!

Generated by 🚫 dangerJS against 25157ca

@openkfwCI
Copy link

openkfwCI commented Apr 8, 2024 •
edited
Loading

NotesTime
❌Note for Reviewer: E2E tests on pipeline 58415 on remote server failedTue, 09 Apr 2024 06:16:29 +0000

Generated by E2E-Test

@SamuelPull SamuelPull merged commit 7010c5e into main Apr 9, 2024
30 checks passed
@SamuelPull SamuelPull deleted the 1753-webp-thumbnails branch April 9, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmolnar-dev pmolnar-dev pmolnar-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Images in TruBudget are large and in jpg format - change to webp and smaller size
3 participants
@SamuelPull @openkfwCI @pmolnar-dev